search

google / jsinterop-generator

Generates Java annotated with JsInterop from JavaScript extern sources
Apache License 2.0
75 stars 24 forks source link

Usage of deprecated union operator #37

Closed danfabi closed 5 years ago

danfabi commented 5 years ago

Builds of elemental2 fail with Bazel 0.26.0 due to the usage of the deprecated "+" operator on depsets (see tracking issue https://github.com/bazelbuild/bazel/issues/5817):

ERROR: /(...)/external/com_google_elemental2/java/elemental2/core/BUILD:38:1: in _jsinterop_generator rule @com_google_elemental2//java/elemental2/core:core__internal_src_generated: 
Traceback (most recent call last):
        File "/(...)/external/com_google_elemental2/java/elemental2/core/BUILD", line 38
                _jsinterop_generator(name = 'core__internal_src_generated')
        File "/(...)/external/com_google_jsinterop_generator/jsinterop_generator.bzl", line 124, in _jsinterop_generator_impl
                _get_generator_files(ctx.attr.deps)
        File "/(...)/external/com_google_jsinterop_generator/jsinterop_generator.bzl", line 49, in _get_generator_files
                transitive_srcs += target_provider.transitive_sources
`+` operator on a depset is forbidden. See https://docs.bazel.build/versions/master/skylark/depsets.html for recommendations. Use --incompatible_depset_union=false to temporarily disable this check.
jDramaix commented 5 years ago

Thanks! I have a cl in review internally that will fix this issue.

jDramaix commented 5 years ago

Need to rollback the cl