google / jsinterop-generator

Generates Java annotated with JsInterop from JavaScript extern sources
Apache License 2.0
75 stars 24 forks source link

If a static property and an instance property are defined on the same type, the instance property is omitted #47

Open niloc132 opened 4 years ago

niloc132 commented 4 years ago

(Discovered while testing #46)

Given this JS, the expected behavior presently is that _STATIC will be appended to the static version since these would otherwise collide. Instead, we see a few different behaviors, I can't yet explain what is happening here:

Example JS:

/**
 * @type {string}
 */
Foo.plainProperty;

/**
 * @type {string}
 */
Foo.prototype.plainProperty;

Resulting Java, with only one field and no _STATIC present on the static member:

  public static String plainProperty;

Example JS:

/**
 * @type {string|number}
 */
Foo.unionProperty;
/**
 * @type {string|number}
 */
Foo.prototype.unionProperty;

Resulting Java (union type omittied), correctly with two fields:

  @JsProperty(name = "unionProperty")
  public static Foo.StaticUnionPropertyUnionType unionProperty_STATIC;

  public Foo.UnionPropertyUnionType unionProperty;