google / json_serializable.dart

Generates utilities to aid in serializing to/from JSON.
https://pub.dev/packages/json_serializable
BSD 3-Clause "New" or "Revised" License
1.55k stars 395 forks source link

Generated code should use a string uri to point at the library it is a part of #1313

Closed jakemac53 closed 1 year ago

jakemac53 commented 1 year ago

Today generated json_serializable code triggers the use_string_in_part_of_directives lint - we should really not be doing this by name but by uri.

jakemac53 commented 1 year ago

(this might actually be a source_gen issue, haven't looked into it)

kevmoo commented 1 year ago

It should follow the pattern used by the part usage from the source library IIRC.

kevmoo commented 1 year ago

Pretty sure this is a source_gen issue, @jakemac53 !

jakemac53 commented 1 year ago

see https://github.com/dart-lang/source_gen/pull/665