search

google / json_serializable.dart

Generates utilities to aid in serializing to/from JSON.
https://pub.dev/packages/json_serializable
BSD 3-Clause "New" or "Revised" License
1.54k stars 393 forks source link

[JsonConverter]: Support generators with constructor arguments #1374

Closed phuongvt closed 8 months ago

phuongvt commented 8 months ago

Support Issue: Can't custom JsonConverter with constructor arguments [#1373]

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

o-nnerb commented 6 months ago

@phuongvt why did you closed this? It's very helpful

phuongvt commented 6 months ago

@o-nnerb because this is my first time creating PR on github, I see @google-cla failed message.

Therefore I close this issue to set up my account correctly and open a new issue here #1375

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

o-nnerb commented 6 months ago

@phuongvt thanks for the clarification! I'm very excited to include this modification into my projects!