search

google / jsonnet

Jsonnet - The data templating language
http://jsonnet.org
Apache License 2.0
6.98k stars 440 forks source link

add loongarch64 support #1120

Closed 212dandan closed 8 months ago

212dandan commented 10 months ago

Please review. If you have any questions, you can contact me at any time.

google-cla[bot] commented 10 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

johnbartholomew commented 8 months ago

Hi. It appears these are changes to Rapid YAML (the copy of the code in the third_party directory) not to jsonnet itself.

It would be better to contribute these changes upstream to the Rapid YAML project (edit: actually to c4core), and then they can be included in jsonnet when we update the Rapid YAML version. You could also check whether Rapid YAML version 0.5.0 already supports this architecture - if so, then I expect jsonnet will pick it up soon (with PR #1134)

johnbartholomew commented 8 months ago

It seems someone has already opened a PR on the c4core project to add support for LoongArch: https://github.com/biojppm/c4core/pull/119

johnbartholomew commented 8 months ago

Thanks for your contribution, however I'm going to close this as it is better to get this into Rapid YAML and not try to maintain a modified version of the Rapid YAML code within jsonnet.