mauvilsa
commented
2 months ago using the github url as dependency
A small update. Having as dependency a github url is not allowed by pypi, so it is not possible to publish a package like this. On upload pypi fails with the following error:
ERROR HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
Can't have direct dependency: jsonnet@
https://github.com/google/jsonnet/zipball/master ; python_version ==
"3.13" and extra == "jsonnet". See
https://packaging.python.org/specifications/core-metadata for more
information.
People have been using jsonnet-binary to have jsonnet working for python in windows. In about three weeks, python 3.13 is coming out, and unfortunately jsonnet-binary does not work anymore. However, I have seen that @johnbartholomew merged https://github.com/google/jsonnet/pull/1137 which seems to fix windows builds here in the official repo, being actually preferable than jsonnet-binary. So I ask, will there be a release soon?
I tested the latest commit in master (using the github url as dependency of jsonargparse), and it worked like a charm, building correctly and all tests passing for python 3.7 up to 3.13. On linux it also worked for all python versions. Though for mac the build fails with
error: invalid argument '-std=c++17' not allowed with 'C', see here.Without a release I can make it work without a release defining the dependency like here pyproject.toml#L59-L61. But this means that an unstable version is used for python 3.13. It would be much better to use an actual release.
Note that there is no need for prebuilt wheel packages. A source distribution just like for jsonnet v0.20.0 would be fine.