google / jwt_verify_lib

Provide c++ library to verify JWT tokens
Apache License 2.0
42 stars 43 forks source link

Add CI docker image and update clang-format to 13 #89

Closed orionHong closed 1 year ago

orionHong commented 1 year ago

Note: CI will fail unless the image is updated in https://github.com/GoogleCloudPlatform/oss-test-infra/pull/1831

Because In this change we updated clang-format from 5.0.0 to 13.0.0, the only issue with the espv2 image now is just bazel. bazelisk was installed there, but we didn't link bazelisk to bazel. We can add cp /usr/local/bin/bazelisk /usr/local/bin/bazel to alias bazelisk to bazel, then we're good.

Having a separate image for this repo has the following benefits

orionHong commented 1 year ago

/retest

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nareddyt, orionHong, qiwzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/jwt_verify_lib/blob/master/OWNERS)~~ [nareddyt,qiwzhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nareddyt commented 1 year ago

Update repo settings to treat jwt-verify-lib-presubmit job as required check

google-oss-prow[bot] commented 1 year ago

New changes are detected. LGTM label has been removed.