search

google / jwt_verify_lib

Provide c++ library to verify JWT tokens
Apache License 2.0
42 stars 43 forks source link

add additional unit tests for long JWTs #93

Closed nareddyt closed 1 year ago

nareddyt commented 1 year ago

Verification that long claims are still decoded and verified successfully

TAOXUY commented 1 year ago

Could you provide some context? Why we need to test these? Anything constrain this lib to verify long JWTs?

nareddyt commented 1 year ago

Could you provide some context? Why we need to test these?

Trying to debug b/271292995. There are no tests in the repo for long JWTs so adding them for future reference.

TAOXUY commented 1 year ago

Comment the length limit are tested against in these test cases?

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nareddyt, TAOXUY

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/jwt_verify_lib/blob/master/OWNERS)~~ [nareddyt] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 1 year ago

New changes are detected. LGTM label has been removed.

nareddyt commented 1 year ago

Comment the length limit are tested against in these test cases?

Added extra comment describing length. Keep in mind the test case name already mentions this