Open michaelpaliy opened 1 year ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: michaelpaliy Once this PR has been reviewed and has the lgtm label, please assign nareddyt for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @michaelpaliy. Thanks for your PR.
I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Related to https://github.com/istio/istio/issues/41729
Currently, there is a validation to check that the exponent is equal to 65537 or 3: https://github.com/google/jwt_verify_lib/blob/master/src/jwks.cc#L107 but the exponent can be any number > 2.
issue https://github.com/google/jwt_verify_lib/issues/96