search

google / jwt_verify_lib

Provide c++ library to verify JWT tokens
Apache License 2.0
42 stars 43 forks source link

Update BoringSSL revision #97

Closed davidben closed 1 year ago

davidben commented 1 year ago

The BoringSSL revision hasn't been updated since 2020. It seems this project tries to track Envoy, so probably should update it to match. https://github.com/envoyproxy/envoy/blob/f4812764c43df5872fd773b25d399f7ff8fa4403/bazel/repository_locations.bzl#L113

Note BoringSSL now requires C++14 (consistent with https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md, for reference Envoy requires C++17), so you may need to update your build. I think it's just a matter of adding build --cxxopt="--std=c++14" to .bazelrc, but I don't really understand Bazel, so that might not be sufficient.

nareddyt commented 1 year ago

Thanks for the link to the support matrix. Good to see we don't need to update clang version, as our repo is pinned to clang-13.

In that case, the only change needed is C++ version. That should be fairly simple.