search

google / kctf

kCTF is a Kubernetes-based infrastructure for CTF competitions. For documentation, see
https://google.github.io/kctf/
Apache License 2.0
665 stars 73 forks source link

return if start_gce fails #359

Closed sroettger closed 2 years ago

sirdarckcat commented 2 years ago

why do we wanna do that? :o

wouldn't that make us miss errors?

sroettger commented 2 years ago

why would we continue if start_operator_gce returned an error already? It just means more unrelated errors?

sirdarckcat commented 2 years ago

oh but then shouldn't we return the error? like return 1 or will return preserve errno

sroettger commented 2 years ago

From help return: If N is omitted, the return status is that of the last command executed within the function or script.

On Thu, Feb 10, 2022 at 11:40 AM sirdarckcat @.***> wrote:

oh but then shouldn't we return the error? like return 1 or will return preserve errno

— Reply to this email directly, view it on GitHub https://github.com/google/kctf/pull/359#issuecomment-1034761382, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEM2JHXCBY6ZW6KEQKY2OSDU2OI2VANCNFSM5OAFQC7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

sirdarckcat commented 2 years ago

cool!