search

google / kernel-sanitizers

Linux Kernel Sanitizers, fast bug-detectors for the Linux kernel
https://google.github.io/kernel-sanitizers/
442 stars 87 forks source link

kfence: no_hash_pointers #178

Closed melver closed 3 years ago

melver commented 3 years ago

If, as Peter said here [1], this gets included in 5.12, the "kfence: .." patch will be sent on Thursday/Friday hopefully in time.

[1] https://lkml.kernel.org/r/YCpWJWkssy7xkgV0@alley

google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

melver commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

Googlers: Go here for more info.

From LKML for inclusion in Linux kernel: https://lkml.kernel.org/r/20210214161348.369023-1-timur@kernel.org

google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

ramosian-glider commented 3 years ago

Do we need all three patches from Timur in our tree? KFENCE part LGTM.

melver commented 3 years ago

Do we need all three patches from Timur in our tree? KFENCE part LGTM.

Yes because unfortunately "lib/vsprintf: no_hash_pointers prints all addresses as unhashed" touches the test.

As soon as KFENCE is in mainline, this branch should be rebased, or preferably dropped/archived if we do not need it anymore (since we could then just use Gerrit for future fixes). So hopefully having those 3 patches here won't bother us for too long.