google / kernel-sanitizers

Linux Kernel Sanitizers, fast bug-detectors for the Linux kernel
https://google.github.io/kernel-sanitizers/
436 stars 87 forks source link

Make KFENCE summary more crisp #217

Closed melver closed 2 years ago

melver commented 2 years ago

To resolve https://github.com/google/kernel-sanitizers/issues/216

xairy commented 2 years ago

I would add a sentence saying that on allocation, with a small probability, KFENCE redirects the allocator to use one of those guarded object.

melver commented 2 years ago

I would add a sentence saying that on allocation, with a small probability, KFENCE redirects the allocator to use one of those guarded object.

Done.

xairy commented 2 years ago

I still feel like a part of logic is missing :)

Paragraph 1 focuses on "KFENCE allocates guarded pages".

Paragraph 2 focuses on "Guarded pages are expensive".

There should a piece in between focusing on "On allocation, KFENCE places objects into these guarded pages".

Paragraph 3 looks great.

melver commented 2 years ago

PTAL