search

google / keytransparency

A transparent and secure way to look up public keys.
https://security.googleblog.com/2017/01/security-through-transparency.html
Apache License 2.0
1.57k stars 151 forks source link

docker-compose includes incorrect entrypoints for Trillian servers #1155

Closed DazWilkin closed 5 years ago

DazWilkin commented 5 years ago

https://github.com/google/keytransparency/blame/master/docker-compose.yml#L55 https://github.com/google/keytransparency/blame/master/docker-compose.yml#L78 https://github.com/google/keytransparency/blame/master/docker-compose.yml#L104

The Dockerfiles for the Trillian services copy the binaries into / not /go/bin

For docker-compose to work, these above entries must be change /go/bin/X --> /X

DazWilkin commented 5 years ago

Thinking about this more while dog-walking, I think it could be better to not override entrypoint in the docker-compose file.

Trillian's Dockerfiles specify the binary as entrypoint and keytransparency appears to do so too....

So.... you can, replace the entrypoint and the binary spec with command and the parameters a e.g.:

    # entrypoint:
    #   - /trillian_log_server
    command:
      - --mysql_uri=test:zaphod@tcp(db:3306)/test
      - --rpc_endpoint=0.0.0.0:8090
      - --http_endpoint=0.0.0.0:8091
      - --alsologtostderr