search

google / kmsan

KernelMemorySanitizer, a detector of uses of uninitialized memory in the Linux kernel
Other
406 stars 63 forks source link

Some crypto configs that use asm are not disabled #80

Closed dvyukov closed 3 years ago

dvyukov commented 4 years ago

We make some crypto configs dependent on !KMSAN. But it does not seem to work in all cases. When running make, I am getting these warnings:

WARNING: unmet direct dependencies detected for CRYPTO_POLY1305_X86_64
  Depends on [n]: CRYPTO [=y] && X86 [=y] && 64BIT [=y] && !KMSAN [=y]
  Selected by [y]:
  - WIREGUARD [=y] && NETDEVICES [=y] && NET_CORE [=y] && NET [=y] && INET [=y] && (IPV6 [=y] || !IPV6 [=y]) && X86 [=y] && 64BIT [=y]

WARNING: unmet direct dependencies detected for CRYPTO_BLAKE2S_X86
  Depends on [n]: CRYPTO [=y] && X86 [=y] && 64BIT [=y] && !KMSAN [=y]
  Selected by [y]:
  - WIREGUARD [=y] && NETDEVICES [=y] && NET_CORE [=y] && NET [=y] && INET [=y] && (IPV6 [=y] || !IPV6 [=y]) && X86 [=y] && 64BIT [=y]

And then these configs are still enabled in the resulting config:

💻 grep CRYPTO_BLAKE2S_X86 .config
CONFIG_CRYPTO_BLAKE2S_X86=y
💻 grep CRYPTO_POLY1305_X86_64 .config
CONFIG_CRYPTO_POLY1305_X86_64=y

This can lead to false positives. We need some other solution.

ramosian-glider commented 3 years ago

Should be fixed now.