Webhook has only namespaced Secret permissions, rather than cluster-w…

google / knative-gcp

GCP event implementations to use with Knative Eventing.

https://github.com/knative/eventing

Apache License 2.0

160 stars 74 forks source link

Webhook has only namespaced Secret permissions, rather than cluster-w… #2025

Closed Harwayne closed 3 years ago

Harwayne commented 3 years ago

Proposed Changes

Webhook has only namespaced Secret permissions, rather than cluster-wide.

Release Note

Webhook no longer has Cluster-wide Secret permissions. Now the Webhook's Secret permissions are restricted to the `cloud-run-events` namespace.

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [Harwayne] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment