search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
160 stars 74 forks source link

Check if spec.retry is nil before dereferencing it. #2052

Closed Harwayne closed 3 years ago

Harwayne commented 3 years ago

Fixes #2051

Proposed Changes

Release Note

- 🐛 Fixed a potential nil pointer dereference when using a GCP Broker.
knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [Harwayne] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tommyreddad commented 3 years ago

/assign

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/trigger/trigger.go 67.1% 67.8% 0.7
tommyreddad commented 3 years ago

Thanks for fixing this!!!

/lgtm