search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
159 stars 75 forks source link

Add auth check into broker ingress pod #2057

Closed grac3gao-zz closed 3 years ago

grac3gao-zz commented 3 years ago

Fixes #

Proposed Changes

Release Note

Add auth check into broker ingress pod

Docs

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grac3gao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [grac3gao] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
grac3gao-zz commented 3 years ago

/assign @Harwayne

zhongduo commented 3 years ago

This may worth a release note, WDYT?

grac3gao-zz commented 3 years ago

@zhongduo done.

zhongduo commented 3 years ago

All the code looks good to me. My only question is: is there any way to fail before this commit in testing?

grac3gao-zz commented 3 years ago

ready for review

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/utils/clients/factories.go Do not exist 60.0%