search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
159 stars 75 forks source link

Always pass upgrade test #2059

Closed zhongduo closed 3 years ago

zhongduo commented 3 years ago

The upgrade test is always failing due to the namespace renaming. Temporarily disable it now.

Need to fix #2020 ASAP.

zhongduo commented 3 years ago

/assign @nlopezgi

nlopezgi commented 3 years ago

we're probably going to have to cherry pick this into the 0.20 branch, but lets wait until release automation runs

nlopezgi commented 3 years ago

/lgtm /approve

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlopezgi, zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [nlopezgi,zhongduo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhongduo commented 3 years ago

/hold

tayarani commented 3 years ago

can you add a TODO or issue link, or a comment on why it's there?

zhongduo commented 3 years ago

/unhold