search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
160 stars 74 forks source link

Revert "Always pass upgrade test (#2059)" #2061

Closed zhongduo closed 3 years ago

zhongduo commented 3 years ago

This reverts commit dc07ee03c5a72795170b78b6140b0f8c3ee7da3d.

Part of #2060

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [zhongduo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhongduo commented 3 years ago

/hold this should be merged after v0.20 is released and cherrypick to v0.20 too. /assign @nlopezgi

zhongduo commented 3 years ago

/test pull-google-knative-gcp-upgrade-tests

zhongduo commented 3 years ago

/retest

nlopezgi commented 3 years ago

/lgtm

zhongduo commented 3 years ago

/unhold

zhongduo commented 3 years ago

/retest