Add authentication check e2e test for BrokerCell

google / knative-gcp

GCP event implementations to use with Knative Eventing.

https://github.com/knative/eventing

Apache License 2.0

159 stars 75 forks source link

Add authentication check e2e test for BrokerCell #2070

Closed grac3gao-zz closed 3 years ago

grac3gao-zz commented 3 years ago

Fixes #

Proposed Changes

Add authentication check e2e test for BrokerCell
As we can't run this test parallel with other sub-test (brokercell is shared), it is added before we configure the right authentication for brokercell (which located in test_setup script)
Only Integration test in secret mode and integration test in wi mode need this test. Since we reuse the test_setup for upgrade test and conformance test, an extra-env ENABLE_AUTH_CHECK_TEST is added into knative/test-infra#2637 to differentiate whether a test workflow needs auth check test or not.

Release Note

Docs

grac3gao-zz commented 3 years ago

/assign @Harwayne

zhongduo commented 3 years ago

So we should merge it after the Prow env var update is changed.

grac3gao-zz commented 3 years ago

@zhongduo I made the new commit after the new test-infra PR merged. https://github.com/knative/test-infra/pull/2639. The most recent test in this PR should be running under the new env value.

zhongduo commented 3 years ago

awesome, thanks. /unhold /approve /lgtm

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grac3gao, zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [grac3gao,zhongduo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment