Extend Probe Helper to cover PingSource

google / knative-gcp

GCP event implementations to use with Knative Eventing.

https://github.com/knative/eventing

Apache License 2.0

159 stars 75 forks source link

Extend Probe Helper to cover PingSource #2079

Closed stuart-xyz closed 3 years ago

stuart-xyz commented 3 years ago

Extends Probe Helper functionality to cover PingSource, a built-in Knative source.

Proposed Changes

Add PingSource HTTP endpoint to Probe Helper, for use by testing infrastructure.
Add Probe Helper PingSource test.

Release Note

Docs

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/schemas/v1/ping.go	Do not exist	100.0%

tommyreddad commented 3 years ago

/lgtm /approve

Thanks for this!!

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuart-xyz, tommyreddad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [tommyreddad] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment