Remove stale liveliness and readiness check in broker ingress

google / knative-gcp

GCP event implementations to use with Knative Eventing.

https://github.com/knative/eventing

Apache License 2.0

159 stars 75 forks source link

Remove stale liveliness and readiness check in broker ingress #2086

Closed grac3gao-zz closed 3 years ago

grac3gao-zz commented 3 years ago

Fixes #

Proposed Changes

Since broker ingress HTTP Receiver is using Drainer for liveliness and readiness check from knative/pkg, this part of the code is stale. remove that with related UT.
New liveliness and readiness related UTs are in https://github.com/google/knative-gcp/blob/master/pkg/utils/clients/factories_test.go#L31

Release Note

Docs

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grac3gao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [grac3gao] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/broker/ingress/handler.go	94.1%	93.8%	-0.3