search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
159 stars 75 forks source link

[WIP] - Test PureEd25519 #2087

Closed Harwayne closed 3 years ago

Harwayne commented 3 years ago

DO NOT SUBMIT

Testing with PureEd25519.

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [Harwayne] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow-robot commented 3 years ago

@Harwayne: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-build-tests 8f1d9ec01ea920a72336ebc8252ee15da84e86a9 link /test pull-google-knative-gcp-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
Harwayne commented 3 years ago

/close

https://github.com/knative/pkg/pull/1998 is the upstream equivalent to the manual changes in this PR and has been merged.

knative-prow-robot commented 3 years ago

@Harwayne: Closed this PR.

In response to [this](https://github.com/google/knative-gcp/pull/2087#issuecomment-765680370): >/close > >https://github.com/knative/pkg/pull/1998 is the upstream equivalent to the manual changes in this PR and has been merged. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.