search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
160 stars 74 forks source link

Use the PublishSettings, rather than always using DefaultPublishSetti… #2093

Closed Harwayne closed 3 years ago

Harwayne commented 3 years ago

Proposed Changes

Release Note

NONE
knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [Harwayne] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tayarani commented 3 years ago

Is this testable? Like adding a simple unit test or e2e test?

Harwayne commented 3 years ago

Is this testable? Like adding a simple unit test or e2e test?

Added a unit test.

tayarani commented 3 years ago

Thanks for adding the test.

/lgtm

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/broker/ingress/multi_topic_decouple_sink.go 83.9% 84.2% 0.3
Harwayne commented 3 years ago

@Harwayne: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command pull-google-knative-gcp-upgrade-tests b82a91b link /test pull-google-knative-gcp-upgrade-tests Full PR test history. Your PR dashboard.

Error from server (InternalError): error when creating "https://storage.googleapis.com/knative-nightly/net-istio/latest/net-istio.yaml": Internal error occurred: failed calling webhook "config.webhook.serving.knative.dev": Post https://webhook.knative-serving.svc:443/config-validation?timeout=10s: no endpoints available for service "webhook"

/retest