Remove unused parameter from storage_admin_set_up - Githubissues

google / knative-gcp

GCP event implementations to use with Knative Eventing.

https://github.com/knative/eventing

Apache License 2.0

160 stars 74 forks source link

Remove unused parameter from storage_admin_set_up #2095

Closed MohamedElhawaty closed 3 years ago

MohamedElhawaty commented 3 years ago

Proposed Changes

This PR could be considered as a followup to https://github.com/google/knative-gcp/pull/1418, it includes further cleanup for the unused parameters in storage_admin_set_up which were mainly used for the outdated curl command.

Release Note

NONE

MohamedElhawaty commented 3 years ago

/assign @zhongduo /assign @AlexandraRoatis

Harwayne commented 3 years ago

Please fill in the PR description.

zhongduo commented 3 years ago

/lgtm

zhongduo commented 3 years ago

/hold

zhongduo commented 3 years ago

/lgtm

zhongduo commented 3 years ago

/unhold

zhongduo commented 3 years ago

/approve

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MohamedElhawaty, zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [MohamedElhawaty,zhongduo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

AlexandraRoatis commented 3 years ago

/lgtm

MohamedElhawaty commented 3 years ago

/test pull-google-knative-gcp-wi-tests