search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
160 stars 74 forks source link

Add subscriber metrics #2096

Closed bharattkukreja closed 3 years ago

bharattkukreja commented 3 years ago

We need a metric which gives us more information about the event subscribers. This helps us in monitoring the services which are receiving events.

As such, we need 3 additional labels for subscriber info:

This metric is similar to the existing event_count metric and measure the same thing. The new labels are added as a new metric by design to ensure backwards compatibility and avoid breaking changes.

Proposed Changes

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bharattkukreja To complete the pull request process, please assign cathyzhyi after the PR has been reviewed. You can assign the PR to them by writing /assign @cathyzhyi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bharattkukreja commented 3 years ago

/hold

knative-prow-robot commented 3 years ago

@bharattkukreja: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 3 years ago

@bharattkukreja: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-wi-tests 6031281678969ef97c610e531d3c3ebf79007c27 link /test pull-google-knative-gcp-wi-tests
pull-google-knative-gcp-upgrade-tests 6031281678969ef97c610e531d3c3ebf79007c27 link /test pull-google-knative-gcp-upgrade-tests
pull-google-knative-gcp-conformance-tests 6031281678969ef97c610e531d3c3ebf79007c27 link /test pull-google-knative-gcp-conformance-tests
pull-google-knative-gcp-go-coverage 6031281678969ef97c610e531d3c3ebf79007c27 link /test pull-google-knative-gcp-go-coverage
pull-google-knative-gcp-integration-tests 6031281678969ef97c610e531d3c3ebf79007c27 link /test pull-google-knative-gcp-integration-tests
pull-google-knative-gcp-build-tests 6031281678969ef97c610e531d3c3ebf79007c27 link /test pull-google-knative-gcp-build-tests
pull-google-knative-gcp-unit-tests 6031281678969ef97c610e531d3c3ebf79007c27 link /test pull-google-knative-gcp-unit-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).