Remove magic 5 seconds in fanout

google / knative-gcp

GCP event implementations to use with Knative Eventing.

https://github.com/knative/eventing

Apache License 2.0

160 stars 74 forks source link

Remove magic 5 seconds in fanout #2098

Closed zhongduo closed 3 years ago

zhongduo commented 3 years ago

Change the magic number to a variable for simplicity.

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [zhongduo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

danyinggu commented 3 years ago

/lgtm