search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
159 stars 75 forks source link

k8s 0.19.7, go 1.15, fix gnostic, remove the ha patch #2102

Closed vaikas closed 3 years ago

vaikas commented 3 years ago

Fixes our automation process for being able to upgrade. Failure can be seen here: https://github.com/knative-sandbox/knobots/runs/1784255996?check_suite_focus=true

Proposed Changes

Release Note

Now uses k8s 0.19.7 libraries, so minimum k8s version is 1.18.

Docs

knative-prow-robot commented 3 years ago

Hi @vaikas. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [Harwayne] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Harwayne commented 3 years ago

/ok-to-test

eclipselu commented 3 years ago

/test pull-google-knative-gcp-wi-tests

Harwayne commented 3 years ago

@vaikas: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command pull-google-knative-gcp-integration-tests f74db74 link /test pull-google-knative-gcp-integration-tests Full PR test history. Your PR dashboard.

I haven't seen this error before:

MountVolume.SetUp failed for volume "google-cloud-key" : failed to sync secret cache: timed out waiting for the condition
vaikas commented 3 years ago

/test pull-google-knative-gcp-integration-tests