Split data plane GSA to broker & sources GSAs in e2e scripts

google / knative-gcp

GCP event implementations to use with Knative Eventing.

https://github.com/knative/eventing

Apache License 2.0

160 stars 74 forks source link

Split data plane GSA to broker & sources GSAs in e2e scripts #2104

Closed MohamedElhawaty closed 3 years ago

MohamedElhawaty commented 3 years ago

Fixes #

Proposed Changes

Add the logic to split the data plane GSA to two separate broker & sources GSAs in the e2e scripts to match our documentation.
Rename variables related to the control plane GSA to be consistent with the other GSAs variables.

Release Note

Docs

MohamedElhawaty commented 3 years ago

/test pull-google-knative-gcp-conformance-tests

MohamedElhawaty commented 3 years ago

/assign @zhongduo /assign @AlexandraRoatis

zhongduo commented 3 years ago

/lgtm /approve /hold just to give others a chance to review, since this is mostly renaming, it should be functionally safe.

AlexandraRoatis commented 3 years ago

/lgtm /approve /unhold

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexandraRoatis, MohamedElhawaty, zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [AlexandraRoatis,MohamedElhawaty,zhongduo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment