search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
159 stars 75 forks source link

Broker does not inspect the response to replies #2106

Closed Harwayne closed 3 years ago

Harwayne commented 3 years ago

Describe the bug When a Trigger replies with an event, that event is sent back to the Broker Ingress. However, our implementation does not inspect the response code of the request to the Broker Ingress, so an event can easily get lost.

Expected behavior If sending the reply to the Broker Ingress fails, then it either needs to be retried or the event needs to be processed by the Trigger again.

Repro See the reply server failure unit test added in #2107, which has a TODO related to this issue.

Harwayne commented 3 years ago

Final sentence in https://github.com/knative/eventing/blob/master/docs/spec/broker.md#delivery, If the reply event was not accepted, the initial event SHOULD be redelivered to the subscriber.