search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
159 stars 75 forks source link

Remove empty spec #2112

Closed zhongduo closed 3 years ago

zhongduo commented 3 years ago

Empty spec will now cause error. The error is about webhook, but I believe this is just because it is not parsed properly.

grac3gao-zz commented 3 years ago

/lgtm

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [grantr,zhongduo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhongduo commented 3 years ago

/retest

zhongduo commented 3 years ago

/retest