Update PS & Topic reconcilers to use Base instead of PubSubBase

google / knative-gcp

GCP event implementations to use with Knative Eventing.

https://github.com/knative/eventing

Apache License 2.0

160 stars 74 forks source link

Update PS & Topic reconcilers to use Base instead of PubSubBase #2116

Closed MohamedElhawaty closed 3 years ago

MohamedElhawaty commented 3 years ago

Proposed Changes

Both PullSubscription and Topic reconcilers are using PubSubBase which is a bit confusing as they don't need the functionalities it offers, changing this to use our reconciler base instead.

Release Note

NONE

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MohamedElhawaty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [MohamedElhawaty] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/intevents/pullsubscription/keda/controller.go	88.9%	88.5%	-0.4
pkg/reconciler/intevents/pullsubscription/static/controller.go	88.5%	88.0%	-0.5
pkg/reconciler/intevents/topic/controller.go	85.0%	84.2%	-0.8