Change the receiver to pointer type

google / knative-gcp

GCP event implementations to use with Knative Eventing.

https://github.com/knative/eventing

Apache License 2.0

159 stars 75 forks source link

Change the receiver to pointer type #2120

Closed cathyzhyi closed 3 years ago

cathyzhyi commented 3 years ago

Proposed Changes

Change the receiver to a pointer:
- to avoid copying when calling those methods
- to update object fields correctly

Release Note

NONE

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cathyzhyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [cathyzhyi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

zhongduo commented 3 years ago

For the second point, is there any test that might capture it?

cathyzhyi commented 3 years ago

For the second point, is there any test that might capture it?

opened an issue for adding unit tests https://github.com/google/knative-gcp/issues/2122