search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
159 stars 75 forks source link

WIP: bisect to find the problem #2123

Closed zhongduo closed 3 years ago

zhongduo commented 3 years ago

Fixes #

Proposed Changes

-

-

Release Note

Docs

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [zhongduo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhongduo commented 3 years ago

release v0.20 works without PR error for two runs.

zhongduo commented 3 years ago

Reverting before #2102 by git revert --no-commit 0c8c969d46f01a0ce0..HEAD, tests passed.

zhongduo commented 3 years ago

Reverting after #2102 , tests passed

zhongduo commented 3 years ago

Second run: Failed in wi test https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/google_knative-gcp/2123/pull-google-knative-gcp-wi-tests/1356749878641823744

zhongduo commented 3 years ago

third run passed.

zhongduo commented 3 years ago

integration test failed with crashloop in net-istio: https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/google_knative-gcp/2123/pull-google-knative-gcp-integration-tests/1356964882360045568

zhongduo commented 3 years ago

/test pull-google-knative-gcp-integration-tests

zhongduo commented 3 years ago

wi failed with "message": "Ingress has not yet been reconciled.", "reason": "IngressNotConfigured",.

zhongduo commented 3 years ago

/retest

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/broker/handler/processors/deliver/processor.go 77.8% 76.1% -1.6
pkg/reconciler/broker/controller.go 65.5% 58.6% -6.9
pkg/reconciler/brokercell/broker_targets_config.go 76.8% 75.9% -0.9
pkg/reconciler/intevents/pullsubscription/keda/controller.go 88.5% 88.9% 0.4
pkg/reconciler/intevents/pullsubscription/static/controller.go 88.0% 88.5% 0.5
pkg/reconciler/intevents/topic/controller.go 84.2% 85.0% 0.8
zhongduo commented 3 years ago

Integration test failed with "message": "Ingress has not yet been reconciled.", "reason": "IngressNotConfigured" https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/google_knative-gcp/2123/pull-google-knative-gcp-integration-tests/1356996345784700928

zhongduo commented 3 years ago

/retest

knative-prow-robot commented 3 years ago

@zhongduo: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 3 years ago

@zhongduo: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-unit-tests 13d5d7b7777894bfd92299e99a23254ef3bf7cb2 link /test pull-google-knative-gcp-unit-tests
pull-google-knative-gcp-build-tests 13d5d7b7777894bfd92299e99a23254ef3bf7cb2 link /test pull-google-knative-gcp-build-tests
pull-google-knative-gcp-go-coverage 13d5d7b7777894bfd92299e99a23254ef3bf7cb2 link /test pull-google-knative-gcp-go-coverage
pull-google-knative-gcp-integration-tests 13d5d7b7777894bfd92299e99a23254ef3bf7cb2 link /test pull-google-knative-gcp-integration-tests
pull-google-knative-gcp-conformance-tests 13d5d7b7777894bfd92299e99a23254ef3bf7cb2 link /test pull-google-knative-gcp-conformance-tests
pull-google-knative-gcp-wi-tests 13d5d7b7777894bfd92299e99a23254ef3bf7cb2 link /test pull-google-knative-gcp-wi-tests
pull-google-knative-gcp-upgrade-tests 13d5d7b7777894bfd92299e99a23254ef3bf7cb2 link /test pull-google-knative-gcp-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
zhongduo commented 3 years ago

Problem not reproducible, but I believe it is related to GKE.