search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
159 stars 75 forks source link

Fail when there is any unavailability during upgrade #2125

Closed zhongduo closed 3 years ago

zhongduo commented 3 years ago

After this commit, any unavailable time during upgrade will be considered as a failure.

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [zhongduo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhongduo commented 3 years ago

/assign @nlopezgi

zhongduo commented 3 years ago

/hold Test one passed. Test two: "detecting unavailable time 168.400925ms". /test pull-google-knative-gcp-upgrade-tests

zhongduo commented 3 years ago

Test three passed. /test pull-google-knative-gcp-upgrade-tests

zhongduo commented 3 years ago

Test four passed. /test pull-google-knative-gcp-upgrade-tests

zhongduo commented 3 years ago

Test five passed. /unhold