Mark pullSubscription as empty when it is deleted

google / knative-gcp

GCP event implementations to use with Knative Eventing.

https://github.com/knative/eventing

Apache License 2.0

159 stars 75 forks source link

Mark pullSubscription as empty when it is deleted #2127

Closed danyinggu closed 3 years ago

danyinggu commented 3 years ago

Fixes #

Proposed Changes

The topic ID and projectID for topic is set to empty when topic is deleted, so does the sinkURI. Mark pullSubscription to be empty to keep them consistent.

Release Note

Docs

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danyinggu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [danyinggu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/intevents/reconciler.go	78.0%	78.2%	0.2

zhongduo commented 3 years ago

/lgtm /retest