Get deployment of receive adapter by deployment's name

google / knative-gcp

GCP event implementations to use with Knative Eventing.

https://github.com/knative/eventing

Apache License 2.0

159 stars 75 forks source link

Get deployment of receive adapter by deployment's name #2128

Closed danyinggu closed 3 years ago

danyinggu commented 3 years ago

Fixes #

Proposed Changes

Previously we get the deployment of receive adapter by labels (controllerAgentName and pullSubscription's name). We could directly get the deployment by its name, because the deployment name of a pullSubscription is generated from UID, which is unique. (https://github.com/google/knative-gcp/blob/350ed608feb43474488be97275723599389d76e2/pkg/reconciler/intevents/pullsubscription/resources/names.go#L44)

Release Note

Docs

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danyinggu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/master/OWNERS)~~ [danyinggu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

zhongduo commented 3 years ago

Ingress not reconciled error in CI: https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/google_knative-gcp/2128/pull-google-knative-gcp-integration-tests/1357110720625381376

/retest

zhongduo commented 3 years ago

/lgtm

danyinggu commented 3 years ago

/retest