Improve probe helper logging

google / knative-gcp

GCP event implementations to use with Knative Eventing.

https://github.com/knative/eventing

Apache License 2.0

160 stars 74 forks source link

Improve probe helper logging #2136

Closed tommyreddad closed 3 years ago

tommyreddad commented 3 years ago

Improve probe helper logging

Proposed Changes

Enable debug-level logging. Otherwise, all debug level log messages are lost.
Use info-level logs for specific probe forward/receive event success.
Use debug-level logs in generic event handling to reduce log clutter.

tommyreddad commented 3 years ago

/assign @stuart-xyz

knative-prow-robot commented 3 years ago

@tommyreddad: GitHub didn't allow me to assign the following users: stuart-xyz.

Note that only google members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/google/knative-gcp/pull/2136#issuecomment-775278222): >/assign @stuart-xyz Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

tommyreddad commented 3 years ago

/retest

stuart-xyz commented 3 years ago

/lgtm /approve

knative-prow-robot commented 3 years ago

@stuart-xyz: changing LGTM is restricted to collaborators

In response to [this](https://github.com/google/knative-gcp/pull/2136#issuecomment-776212348): >/lgtm >/approve Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuart-xyz, tommyreddad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/main/OWNERS)~~ [tommyreddad] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

danyinggu commented 3 years ago

/retest /lgtm

tommyreddad commented 3 years ago

/test pull-google-knative-gcp-upgrade-tests