Closed tommyreddad closed 3 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: tommyreddad
The full list of commands accepted by this bot can be found here.
The pull request process is described here
The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/reconciler/trigger/trigger.go | 58.0% | 67.6% | 9.6 |
/retest
/lgtm
/hold This issue is already fixed by the latest master code, can you make sure the logic are the same?
I cherry-picked the commit, it is the same logic. You can check the original to see it is the same: https://github.com/google/knative-gcp/pull/2052
/unhold
/retest
/retest
/retest
/lgtm
/retest
/retest
Fixes #2051
Proposed Changes
Release Note