Remove Channel's status.topic.

google / knative-gcp

GCP event implementations to use with Knative Eventing.

https://github.com/knative/eventing

Apache License 2.0

160 stars 74 forks source link

Remove Channel's status.topic. #2149

Closed Harwayne closed 3 years ago

Harwayne commented 3 years ago

Follow up from #2034.

Proposed Changes

Remove Channel's status.topic.
- This Topic is the Channel's decoupling Topic, which has no meaning or utility to users. It is an internal detail of the Channel and doesn't need to be persisted.

Release Note

Channel's `status.topic` has been removed, as it was purely an internal implementation detail.

Harwayne commented 3 years ago

/assign @zhongduo

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/messaging/v1beta1/channel_lifecycle.go	78.3%	77.3%	-1.0

zhongduo commented 3 years ago

/lgtm /retest

zhongduo commented 3 years ago

/approve

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/main/OWNERS)~~ [zhongduo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment