search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
160 stars 74 forks source link

[WIP]: dataplane readiness guarantee #2155

Closed cathyzhyi closed 3 years ago

cathyzhyi commented 3 years ago

Fixes #

Proposed Changes

-

-

Release Note

Docs

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cathyzhyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/main/OWNERS)~~ [cathyzhyi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/broker/v1beta1/trigger_lifecycle.go 94.7% 87.8% -6.9
pkg/broker/config/key.go 72.6% 57.7% -14.9
pkg/utils/list.go Do not exist 0.0%
knative-prow-robot commented 3 years ago

@cathyzhyi: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-go-coverage 409010e2b132fe70f7941041714f677e5504603e link /test pull-google-knative-gcp-go-coverage
pull-google-knative-gcp-unit-tests 409010e2b132fe70f7941041714f677e5504603e link /test pull-google-knative-gcp-unit-tests
pull-google-knative-gcp-build-tests 409010e2b132fe70f7941041714f677e5504603e link /test pull-google-knative-gcp-build-tests
pull-google-knative-gcp-upgrade-tests 409010e2b132fe70f7941041714f677e5504603e link /test pull-google-knative-gcp-upgrade-tests
pull-google-knative-gcp-conformance-tests 409010e2b132fe70f7941041714f677e5504603e link /test pull-google-knative-gcp-conformance-tests
pull-google-knative-gcp-integration-tests 409010e2b132fe70f7941041714f677e5504603e link /test pull-google-knative-gcp-integration-tests
pull-google-knative-gcp-wi-tests 409010e2b132fe70f7941041714f677e5504603e link /test pull-google-knative-gcp-wi-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).