google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
160 stars 74 forks source link

Revert namespace rename #2158

Closed AlexandraRoatis closed 3 years ago

AlexandraRoatis commented 3 years ago

Fixes #

Proposed Changes

Release Note

Revert namespace rename back to `cloud-run-events`.

Docs

AlexandraRoatis commented 3 years ago

I accidentally used the old master branch. Rebasing now.

MohamedElhawaty commented 3 years ago

Should this include removing the namespace-transition documentation as well?

AlexandraRoatis commented 3 years ago

/hold until #2161 is merged and released

MohamedElhawaty commented 3 years ago

/test pull-google-knative-gcp-upgrade-tests

MohamedElhawaty commented 3 years ago

/lgtm /approve

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MohamedElhawaty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/main/OWNERS)~~ [MohamedElhawaty] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nlopezgi commented 3 years ago

/lgtm

AlexandraRoatis commented 3 years ago

/unhold