search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
160 stars 74 forks source link

Revert namespace update on release 0.20 #2161

Closed AlexandraRoatis closed 3 years ago

AlexandraRoatis commented 3 years ago

Proposed Changes

Release Note

Revert back to `cloud-run-events` namespace name.

Docs

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/intevents/pullsubscription/keda/controller.go 88.5% 88.9% 0.4
pkg/reconciler/intevents/pullsubscription/static/controller.go 88.0% 88.5% 0.5
pkg/reconciler/intevents/topic/controller.go 84.2% 85.0% 0.8
pkg/reconciler/messaging/channel/controller.go 75.9% 86.7% 10.8
MohamedElhawaty commented 3 years ago

/lgtm /hold to give others a chance to review.

nlopezgi commented 3 years ago

/lgtm

zhongduo commented 3 years ago

/lgtm /unhold

zhongduo commented 3 years ago

/approve

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/release-0.20/OWNERS)~~ [zhongduo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment