search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
159 stars 75 forks source link

Use CloudPubSubSource in TriggerDependencyAnnotationTest #2180

Closed eclipselu closed 3 years ago

eclipselu commented 3 years ago

Proposed Changes

Release Note

Docs

eclipselu commented 3 years ago

/retest

eclipselu commented 3 years ago

/test pull-google-knative-gcp-unit-tests

eclipselu commented 3 years ago

/test pull-google-knative-gcp-wi-tests

eclipselu commented 3 years ago

@tommyreddad @zhongduo pls take a look when you are free. Thanks!

tommyreddad commented 3 years ago

/lgtm

tommyreddad commented 3 years ago

/approve

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tommyreddad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/main/OWNERS)~~ [tommyreddad] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment