Filter brokerCell resource updates by label

google / knative-gcp

GCP event implementations to use with Knative Eventing.

https://github.com/knative/eventing

Apache License 2.0

160 stars 74 forks source link

Filter brokerCell resource updates by label #2187

Closed tommyreddad closed 3 years ago

tommyreddad commented 3 years ago

Without filtering these updates, the controller debug logs get polluted with many irrelevant messages, for example:

controller-5c5d65bccd-vpr8p controller {"level":"debug","ts":"2021-03-23T18:43:17.186Z","logger":"controller.github.com-google-knative-gcp-pkg-reconciler-brokercell.Reconciler","caller":"controller/controller.go:335","msg":"Object kube-system/cluster-autoscaler-status does not have a referring name label brokerCell"}

Proposed Changes

🧽 Filter brokerCell resource updates by label.

cathyzhyi commented 3 years ago

/lgtm /approve

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cathyzhyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/main/OWNERS)~~ [cathyzhyi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

tommyreddad commented 3 years ago

/retest