search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
160 stars 74 forks source link

Update deps and to release 0.22 branch #2196

Closed nlopezgi closed 3 years ago

nlopezgi commented 3 years ago

Running RELEASE=0.22 ./hack/update-deps.sh --upgrade --release ${RELEASE} ./hack/update-codegen.sh

to prepare for 0.22 release branch cut Had to remove some conversion code in pkg/apis/convert/conversion_helper.go pkg/testing/test_helper.go as the v1alpha1 deps have been removed from upstream

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from nlopezgi after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/google/knative-gcp/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nlopezgi commented 3 years ago

checking if tests will pass /hold

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/convert/conversion_helper.go 96.4% 97.4% 1.0
knative-prow-robot commented 3 years ago

@nlopezgi: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-upgrade-tests d9b94e65e3559f1e35f5880832185d3f793f77db link /test pull-google-knative-gcp-upgrade-tests
pull-google-knative-gcp-wi-tests d9b94e65e3559f1e35f5880832185d3f793f77db link /test pull-google-knative-gcp-wi-tests
pull-google-knative-gcp-integration-tests d9b94e65e3559f1e35f5880832185d3f793f77db link /test pull-google-knative-gcp-integration-tests
pull-google-knative-gcp-conformance-tests d9b94e65e3559f1e35f5880832185d3f793f77db link /test pull-google-knative-gcp-conformance-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
nlopezgi commented 3 years ago

https://github.com/google/knative-gcp/pull/2197 fixes underlying issues here. Will send a new PR after that is in.