search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
159 stars 75 forks source link

Replace usage of eventing v1beta1 APIs with v1 #2197

Closed grantr closed 3 years ago

grantr commented 3 years ago

The v1beta1 versions of Broker and Trigger have been removed from upstream. The v1 version has an identical schema, so replacing is just import juggling.

This should unblock the auto dependency update.

Proposed Changes

Release Note

## Action Required
The v1beta1 versions of Broker and Trigger are no longer supported. Please switch to the v1 versions of these resources (schema is identical).
grantr commented 3 years ago

/approve

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/main/OWNERS)~~ [grantr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
grantr commented 3 years ago

Seems like we inherited the change to remove self-approval from Knative test-infra. This change is likely to be reverted in Knative, so we probably don't need to do anything to revert it ourselves.

grantr commented 3 years ago

/retest

grantr commented 3 years ago

/retest

danyinggu commented 3 years ago

It seems like we need to run update-codegen.sh again.

grantr commented 3 years ago

I'm unable to get Prow's update-codegen.sh output locally. When I run it I don't get a diff. Maybe I have an environment difference?

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/broker/v1/broker_defaults.go Do not exist 86.7%
pkg/apis/broker/v1/broker_lifecycle.go Do not exist 100.0%
pkg/apis/broker/v1/broker_types.go Do not exist 100.0%
pkg/apis/broker/v1/broker_validation.go Do not exist 100.0%
pkg/apis/broker/v1/register.go Do not exist 100.0%
pkg/apis/broker/v1/test_helper.go Do not exist 96.2%
pkg/apis/broker/v1/trigger_defaults.go Do not exist 100.0%
pkg/apis/broker/v1/trigger_lifecycle.go Do not exist 94.7%
pkg/apis/broker/v1/trigger_types.go Do not exist 100.0%
pkg/apis/broker/v1/trigger_validation.go Do not exist 100.0%
pkg/apis/convert/conversion_helper.go 96.4% 97.3% 0.9
knative-prow-robot commented 3 years ago

@grantr: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-build-tests 58f31716668493473a36d6e6fcdc04fa8ad21719 link /test pull-google-knative-gcp-build-tests
pull-google-knative-gcp-upgrade-tests 58f31716668493473a36d6e6fcdc04fa8ad21719 link /test pull-google-knative-gcp-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).