google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
159 stars 75 forks source link

Upgrade to eventing v1 apis and eventing 0.22 #2199

Closed grantr closed 3 years ago

grantr commented 3 years ago

Alternate, smaller-scope version of #2197, upgrading to 0.22 instead of head (0.23).

The v1beta1 versions of Broker and Trigger have been removed from upstream. The v1 version has an identical schema, so replacing is just import juggling.

This should unblock the auto dependency update.

Proposed Changes

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/broker/v1/broker_defaults.go Do not exist 86.7%
pkg/apis/broker/v1/broker_lifecycle.go Do not exist 100.0%
pkg/apis/broker/v1/broker_types.go Do not exist 100.0%
pkg/apis/broker/v1/broker_validation.go Do not exist 100.0%
pkg/apis/broker/v1/register.go Do not exist 100.0%
pkg/apis/broker/v1/test_helper.go Do not exist 96.2%
pkg/apis/broker/v1/trigger_defaults.go Do not exist 100.0%
pkg/apis/broker/v1/trigger_lifecycle.go Do not exist 94.7%
pkg/apis/broker/v1/trigger_types.go Do not exist 100.0%
pkg/apis/broker/v1/trigger_validation.go Do not exist 100.0%
pkg/apis/convert/conversion_helper.go 96.4% 97.3% 0.9
tommyreddad commented 3 years ago

/test pull-google-knative-gcp-wi-tests

zhongduo commented 3 years ago

/lgtm /approve

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/knative-gcp/blob/main/OWNERS)~~ [zhongduo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment