search

google / knative-gcp

GCP event implementations to use with Knative Eventing.
https://github.com/knative/eventing
Apache License 2.0
159 stars 75 forks source link

Use nightly serving and eventing in e2e tests #2203

Closed tommyreddad closed 3 years ago

tommyreddad commented 3 years ago

Fixes #2201

We temporarily pinned the serving and eventing versions in e2e tests in order to get confidence about the upgrade tests passing due to eventing nightly being incompatible with knative-gcp at the time. Now we should go back to testing against serving and eventing nightly.

Proposed Changes

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from tommyreddad after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/google/knative-gcp/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tommyreddad commented 3 years ago

/test pull-google-knative-gcp-upgrade-tests

tommyreddad commented 3 years ago

/test pull-google-knative-gcp-upgrade-tests

tommyreddad commented 3 years ago

The upgrade test is still running with cloud-run-events 0.21 which has the incompatible Broker v1beta1 type, so that's why it is failing.

tommyreddad commented 3 years ago

/test pull-google-knative-gcp-upgrade-tests

tommyreddad commented 3 years ago

/test pull-google-knative-gcp-upgrade-tests

knative-prow-robot commented 3 years ago

@tommyreddad: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-upgrade-tests 423a004a7de08e0ebc99aa4269689a2760939868 link /test pull-google-knative-gcp-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tommyreddad commented 3 years ago

Unpinning the versions in #2205 instead since the tests here still use v1beta1 Broker.